-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: for keychain lock issue while during notorization arm64 dmg #950
Conversation
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/ci_beta.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/ci_beta.yml (2)
66-77
: The notarization job for the x86_64 architecture looks good.
78-86
: The notarization job for the aarch64 architecture looks good. Ensure the keychain profile name "ide-notarytool-profile-arm64" is unique to avoid conflicts.Verification successful
The notarization job for the aarch64 architecture looks good. The keychain profile name "ide-notarytool-profile-arm64" is unique and does not conflict with any existing profiles.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the uniqueness of the keychain profile name. # Test: Search for the keychain profile name. Expect: Only occurances of the new profile name. rg --type yaml $'ide-notarytool-profile-arm64'Length of output: 45
Script:
#!/bin/bash # Description: Verify the uniqueness of the keychain profile name across all file types. # Test: Search for the keychain profile name. Expect: Only occurrences of the new profile name. rg 'ide-notarytool-profile-arm64'Length of output: 33
Description
Please include a summary of the change and which issue is fixed.
Fixes # (IEP-XXX)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit